linux-kernel - Re: [Bug #12422] 2.6.28-git can't resume from str

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Jan 2009 02:28:00 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Jeff Chua <jeff.chua.linux@...il.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Christian Borntraeger <borntraeger@...ibm.com>,
	Daniel Drake <dsd@...too.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Kernel Testers List <kernel-testers@...r.kernel.org>,
	Phil Dibowitz <phil@...m.com>
Subject: Re: [Bug #12422] 2.6.28-git can't resume from str


* Jeff Chua <jeff.chua.linux@...il.com> wrote:

> On Mon, Jan 12, 2009 at 2:07 AM, Ingo Molnar <mingo@...e.hu> wrote:
> >> Everything in-between should have
> >> a0e280e0f33f6c859a235fb69a875ed8f3420388 applied?
> > not necessarily - if an intermediate tree that is checked happened to have
> > been based on some earlier -rc, it might have that bug included. Safest is
> > to always cherry-pick that commit. (if it has no dependencies)
> 
> Thanks for pointing this out. My bisect was thrown off course because
> I didn't "cherry-pick" that commit.
> 
> After cherry picking, I ended up with the same commit as was reported by
> Christian Borntraeger -- "Regression 2.6.28-git: suspend/resume
> failure. git bisected to usb suspend/resume patch".
> 
> I was trying to bisect further, but ended up with this strange behavior...
> 
> # start with a "fresh linux git download".
> # ls
> .               ..             .git     .gitignore   .mailmap  COPYING
> CREDITS         Documentation  Kbuild   MAINTAINERS  Makefile  README
> REPORTING-BUGS  arch           block    crypto       drivers   firmware
> fs              include        init     ipc          kernel    lib
> mm              net            samples  scripts      security  sound
> usr             virt
> 
> # git bisect bad ae04d1401577bb63151480a053057de58b8e10bb
> # git bisect good a3a798c88a14b35e5d4ca30716dbc9eb9a1ddfe2
> Bisecting: 579 revisions left to test after this
> [079899c2384023cd8efcd3806680b4f1d2abbd54] Btrfs: Change
> find_extent_buffer to use TestSetPageLocked
> 
> # ls
> .  ..  .git  fs
> 
> Is this a bug or a feature?

that's a feature - the btrfs history looks like this. You can mark get out 
of that bisection set by doing this:

        git bisect good 34353029534a08e41cfb8be647d734b9ce9ebff8

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/