linux-kernel - Re: [linux-dvb] compiling on 2.6.28 broken?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 Jan 2009 09:23:54 +1100
From:	Dave Chinner <david@...morbit.com>
To:	wk <handygewinnspiel@....de>
Cc:	Chris Mason <chris.mason@...cle.com>,
	Matthew Wilcox <matthew@....cx>,
	Andrew Morton <akpm@...ux-foundation.org>, rjw@...k.pl,
	HWerner4@....de, viro@...iv.linux.org.uk,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	mchehab@...radead.org
Subject: Re: [linux-dvb] compiling on 2.6.28 broken?

On Thu, Jan 15, 2009 at 08:41:40PM +0100, wk wrote:
> Dave Chinner wrote:
>> It's obviously the regression fixed by:
>>
>> http://oss.sgi.com/cgi-bin/gitweb.cgi?p=xfs/xfs.git;a=commit;h=15440319767942a363f282d6585303d3d75088ba
>>
>> It needs to be pushed to Linus, then into 2.6.28-stable.
>
> Yes, that solves the problems as expected. But may i kindly ask the xfs  
> fs developers to put some more readable patch here,
> so that its better understandable by looking at the source code? I think  
> some macro would be better here, for example i used
>
> #define TRUNC_TO_SIGNED32(x) (x & 0x7FFFFFFF)
>
> inside xfs.h and replaced all "foo & 0x7fffffff" with  
> "TRUNC_TO_SIGNED32(foo)".

>From the commit description:

"The patch below is a dumb version of just putting back the masking,
 to make sure we have the same behavior as in 2.6.27 and earlier.

 I will work on a better and cleaner fix for 2.6.30."

And in more detail, read the review thread:

http://oss.sgi.com/archives/xfs/2008-12/msg01168.html

Cheers,

Dave.
-- 
Dave Chinner
david@...morbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/