linux-kernel - Re: [PATCH 2/3] drivers/gpu/drm: fix sparse warnings: unexport symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 18 Jan 2009 21:48:19 +0530
From:	Jaswinder Singh Rajput <jaswinder@...nel.org>
To:	Hannes Eder <hannes@...neseder.net>
Cc:	dri-devel@...ts.sourceforge.net, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] drivers/gpu/drm: fix sparse warnings: unexport
 symbols

On Sun, 2009-01-18 at 17:04 +0100, Hannes Eder wrote:
> >>  /**
> >> diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
> >> index 7c36f16..c0cfe39 100644
> >> --- a/drivers/gpu/drm/drm_modes.c
> >> +++ b/drivers/gpu/drm/drm_modes.c
> >> @@ -357,9 +357,9 @@ EXPORT_SYMBOL(drm_mode_validate_size);
> >>   * sure each mode falls within a given range (defined by @min and @max
> >>   * arrays) and sets @mode->status as needed.
> >>   */
> >> -void drm_mode_validate_clocks(struct drm_device *dev,
> >> -                           struct list_head *mode_list,
> >> -                           int *min, int *max, int n_ranges)
> >> +static void drm_mode_validate_clocks(struct drm_device *dev,
> >> +                                  struct list_head *mode_list,
> >> +                                  int *min, int *max, int n_ranges)
> >>  {
> >>       struct drm_display_mode *mode;
> >>       int i;
> >> @@ -376,7 +376,6 @@ void drm_mode_validate_clocks(struct drm_device *dev,
> >>                       mode->status = MODE_CLOCK_RANGE;
> >>       }
> >>  }
> >> -EXPORT_SYMBOL(drm_mode_validate_clocks);
> >
> > ??
> 
> In both cases: a grep over the entire kernel tree shows that the
> function is only used within the compilation unit it is defined,
> therefore make it static and un-EXPORT it.

If it is EXPORTED you cannot make it static. EXPORTED means it can be
used from a kernel module.

you need to define the declaration of these functions on related header
file to fix these sparse warnings.

--
JSR


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/