linux-kernel - [PATCH] net/9p: fid->fid is used uninitialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 18 Jan 2009 20:10:25 +0100
From:	Roel Kluin <roel.kluin@...il.com>
To:	Eric Van Hensbergen <ericvh@...il.com>, rminnich@...dia.gov,
	lucho@...kov.net
CC:	v9fs-developer@...ts.sourceforge.net,
	lkml <linux-kernel@...r.kernel.org>
Subject: [PATCH] net/9p: fid->fid is used uninitialized

I appear to have introduced this myself trying to fix a
signed/unsigned issue, sorry.
---
fid->fid is used uninitialized

Signed-off-by: Roel Kluin <roel.kluin@...il.com>
---
diff --git a/net/9p/client.c b/net/9p/client.c
index 821f1ec..1eb580c 100644
--- a/net/9p/client.c
+++ b/net/9p/client.c
@@ -618,7 +618,7 @@ static struct p9_fid *p9_fid_create(struct p9_client *clnt)
 		return ERR_PTR(-ENOMEM);
 
 	ret = p9_idpool_get(clnt->fidpool);
-	if (fid->fid < 0) {
+	if (ret < 0) {
 		ret = -ENOSPC;
 		goto error;
 	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/