linux-kernel - staging driver (epl)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 20 Jan 2009 00:03:15 +0300
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	gregkh@...e.de
Cc:	linux-kernel@...r.kernel.org
Subject: staging driver (epl)

Greg, can I ssh to your box to do

	git rm -rf drivers/staging/epl
	sed -i -e '/epl/d' drivers/staging/Kconfig
	sed -i -e '/CONFIG_EPL/d' drivers/staging/Makefile
	git commit -a -m 'staging: remove epl driver'

?

This driver doesn't meet even _the_ basic requirements.

It's _full_ of hungarian notation (iRet).

It's full of typedefs.

It's full of HAL (tEplApiInstance etc).

Filenames (!) are in CamelCase.

It creates sockets from kernel for something.

It tries to interact with devfs.

It may come as surprise but you also committed real Win32 code:

	drivers/staging/epl/EplTimeruWin32.c
	drivers/staging/epl/ShbIpc-Win32.c

Amazing, isn't it?

Do you accept _any_ code? Exactly zero entry barrier?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/