linux-kernel - Re: [PATCH] x86_64: remove kernel_physical_mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 20 Jan 2009 00:32:27 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Gary Hade <garyhade@...ibm.com>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	yhlu.kernel@...il.com, lcm@...ibm.com, x86@...nel.org
Subject: Re: [PATCH] x86_64: remove kernel_physical_mapping_init() from
	init section


* Gary Hade <garyhade@...ibm.com> wrote:

> kernel_physical_mapping_init() is called during memory hotplug so it 
> does not belong in the init section.
> 
> If the kernel is built with CONFIG_DEBUG_SECTION_MISMATCH=y on the make 
> command line, arch/x86/mm/init_64.c is compiled with the 
> -fno-inline-functions-called-once gcc option defeating inlining of 
> kernel_physical_mapping_init() within init_memory_mapping(). When 
> kernel_physical_mapping_init() is not inlined it is placed in the 
> .init.text section according to the __init in it's current declaration.  
> A later call to kernel_physical_mapping_init() during a memory hotplug 
> operation encounters an int3 trap because the .init.text section memory 
> has been freed.  This patch eliminates the crash caused by the int3 trap 
> by moving the non-inlined kernel_physical_mapping_init() from .init.text 
> to .meminit.text.
> 
> Signed-off-by: Gary Hade <garyhade@...ibm.com>

applied to tip/x86/urgent, thanks Gary!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/