linux-kernel - Re: [PATCH] mb862xx: Restrict compliation of platform driver to PPC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 20 Jan 2009 13:00:19 +1100
From:	Julian Calaby <julian.calaby@...il.com>
To:	avorontsov@...mvista.com
Cc:	linux-kernel@...r.kernel.org, linuxppc-dev@...abs.org,
	Anatolij Gustschin <agust@...x.de>,
	Dmitry Baryshkov <dbaryshkov@...il.com>,
	Matteo Fortini <m.fortini@...comgroup.com>,
	Krzysztof Helt <krzysztof.h1@...zta.fm>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] mb862xx: Restrict compliation of platform driver to PPC

On Tue, Jan 20, 2009 at 12:19, Anton Vorontsov <avorontsov@...mvista.com> wrote:
> Should be Anatolij. ;-)

Who is the first person on the list, I guess he's missed this or isn't
reading his email.

> But I'm interested in this driver as well.
>
> FWIW, the patch looks OK, except for the long lines in the commit log.

I don't expect this to be applied as is. There is a better fix out
there, but I don't know the hardware so I'm not sure what it is.

> Also you'd better mention exact build error in the commit log.

Essentially it's a huge list of missing definitions for functions
which aren't defined for SPARC. I'll reply with it if you really want
it, however they look to be PPC specific. If they were generic I would
have simply included the correct files so that it compiled, rather
than this nasty hack.

It also appears that these functions are not defined in the headers
that this driver includes.

> (Btw, we'd better fix the build for sparc instead of adding another
> "depends on". Could anybody point to some recent, working sparc cross
> toolchain? Last time I googled for it I found only some prehistoric
> versions that I didn't bother to try...)

Before we commit to fixing this properly, is it really worth it? Is
this hardware ever likely to be used with SPARC?

Given that there are PCI and OF versions of the driver, it seems to me
that this is available as a PCI expansion card, and as a graphics chip
built into some PPC motherboards. The initial commit says: "Lime GDC
support is known to work on PPC440EPx based lwmon5 and MPC8544E based
socrates embedded boards, both equipped with Lime GDC." so I'm
guessing that this graphics chip is designed for embedded boards. I
can find references to it's use in embedded automotive applications on
Google but I can't find any reference to the Fujitsu LIME (MB86276)
and SPARC on Google.

Note that the PCI version of this driver compiles fine with both
allyesconfig and allmodconfig.

If you're sure you want to do this, I'd check out crosstool for a
SPARC cross-complier.

Two other things:
1. SPARC32 and SPARC64 can be compiled with the same compiler.
2. These two platforms have slightly different OpenFirmware interfaces
- so fixing it for both of these will be a pain.

Thanks,

-- 

Julian Calaby

Email: julian.calaby@...il.com
.Plan: https://sites.google.com/site/juliancalaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/