linux-kernel - Re: Confusion in usr/include/linux/videodev.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 21 Jan 2009 10:09:13 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Jaswinder Singh Rajput <jaswinderlinux@...il.com>
Cc:	Trent Piepho <xyzzy@...akeasy.org>,
	Mauro Carvalho Chehab <mchehab@...radead.org>,
	Jaswinder Singh Rajput <jaswinder@...nel.org>,
	linux-media@...r.kernel.org, video4linux-list@...hat.com,
	Sam Ravnborg <sam@...nborg.org>, Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: Confusion in usr/include/linux/videodev.h

On Wednesday 21 January 2009, Jaswinder Singh Rajput wrote:

> > diff -r 29c5787efcda linux/include/linux/videodev.h
> > --- a/linux/include/linux/videodev.h    Thu Jan 15 09:07:03 2009 -0800
> > +++ b/linux/include/linux/videodev.h    Wed Jan 21 00:51:45 2009 -0800
> > @@ -15,7 +15,8 @@
> >  #include <linux/ioctl.h>
> >  #include <linux/videodev2.h>
> >
> > -#if defined(CONFIG_VIDEO_V4L1_COMPAT) || !defined (__KERNEL__)
> > +#if (defined(__KERNEL__) && defined(CONFIG_VIDEO_V4L1_COMPAT)) \
> > +    || !defined (__KERNEL__)
> >
> >  #define VID_TYPE_CAPTURE       1       /* Can capture */
> >  #define VID_TYPE_TUNER         2       /* Can tune */
> >
> > Now CONFIG_VIDEO_V4L1_COMPAT will only be used in the kernel.
> >
> 
> No, this will still give warnings.

You could #define another conditional, like this:

#ifndef __KERNEL__
# define __V4L1_COMPAT_API /* Always provide definitions to user space */
#else /* __KERNEL__ */
# ifdef CONFIG_VIDEO_V4L1_COMPAT
#  define __V4L1_COMPAT_API
# endif /* CONFIG_VIDEO_V4L1_COMPAT /*
#endif /* __KERNEL__ */

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/