linux-kernel - Re: [git pull] m68k and m68knommu merge of includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 21 Jan 2009 13:38:58 +1000
From:	Greg Ungerer <gerg@...pgear.com>
To:	Harvey Harrison <harvey.harrison@...il.com>
CC:	torvalds@...ux-foundation.org, arnd@...db.de, gerg@...inux.org,
	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-m68k@...r.kernel.org, sam@...nborg.org,
	uclinux-dev@...inux.org, zippel@...ux-m68k.org
Subject: Re: [git pull] m68k and m68knommu merge of includes

Hi Harvey,

Harvey Harrison wrote:
> On Wed, 2009-01-21 at 10:58 +1000, Greg Ungerer wrote:
>> Hi Linus,
>>
>> Please consider pulling this merge of the m68k and m68knommu include files.
>> It comepletely moves include/asm-m68k to arch/m68k/include as part of the
>> process, and ultimately results in both m68k and m68knommu arch code using
>> the same set of includes. More cleanup can follow, but this is the
>> necessary first step.
>>
>> Thanks
>> Greg
> 
> I think you need to check your arch/m68k/include/asm/swab.h as I get an
> empty file when I pull this.  It looks like it needs a conditional 
> include of swab_mm/swab_no similar to the other files.

Yes, something went wrong there...


> Also, because of the byteorder changes, it looks like you don't need
> a separate byteorder_mm/no as they both just include the generic
> include/linux/byteorder/big_endian.h

Are you happy to just apply your follow up patch to fix these issues,
after this has been pulled?

Regards
Greg


------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@...pgear.com
SnapGear, a McAfee Company                  PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/