linux-kernel - Re: [PATCH 4/5] debugfs: introduce stub for debugfs_create_size_t() when DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 22 Jan 2009 10:22:14 -0800
From:	Greg KH <gregkh@...e.de>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	linux-kernel@...r.kernel.org,
	Inaky Perez-Gonzalez <inaky@...ux.intel.com>,
	Linus <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 4/5] debugfs: introduce stub for
	debugfs_create_size_t() when DEBUG_FS=n

On Thu, Jan 22, 2009 at 05:41:52PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> On Tue, 20 Jan 2009 21:19:56 -0800 Greg Kroah-Hartman <gregkh@...e.de> wrote:
> >
> > From: Inaky Perez-Gonzalez <inaky@...ux.intel.com>
> > 
> > Toralf Förster <toralf.foerster@....de> reported a build failure in
> > the WiMAX stack when CONFIG_DEBUG_FS=n
> > 
> > http://linuxwimax.org/pipermail/wimax/2009-January/000449.html
> > 
> > This is due to debugfs_create_size_t() missing an stub that returns
> > -ENODEV when the DEBUGFS subsystem is not configured in (like the rest
> > of the debugfs API).
> > 
> > This patch adds said stub.
> > 
> > Reported-by: Toralf Förster <toralf.foerster@....de>
> > Signed-off-by: Inaky Perez-Gonzalez <inaky@...ux.intel.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
> > ---
> >  include/linux/debugfs.h |    7 +++++++
> >  1 files changed, 7 insertions(+), 0 deletions(-)
> > 
> > diff --git a/include/linux/debugfs.h b/include/linux/debugfs.h
> > index 23936b1..0f5c33b 100644
> > --- a/include/linux/debugfs.h
> > +++ b/include/linux/debugfs.h
> > @@ -162,6 +162,13 @@ static inline struct dentry *debugfs_create_x32(const char *name, mode_t mode,
> >  	return ERR_PTR(-ENODEV);
> >  }
> >  
> > +struct dentry *debugfs_create_size_t(const char *name, mode_t mode,
> 
> This needs to be "static inline".  See my other email about linux-next
> breakage due to this.

This is now resolved in my tree, sorry about this.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/