| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 23 Jan 2009 00:11:31 +0100 From: Frans Pop <elendil@...net.nl> To: Pavel Machek <pavel@...e.cz> Cc: linux-kernel@...r.kernel.org Subject: Re: HP accelerometer driver: testers wanted Minor issue in the patch: hpfall.c should not be executable: -rwxr-xr-x 1 fjp fjp 1759 2009-01-22 23:31 hpfall.c With patch applied: $ ls -l /dev/freefall crw-rw---- 1 root root 10, 59 2009-01-22 23:44 /dev/freefall $ gcc -o hpfall -Os hpfall.c hpfall.c: In function ‘main’: hpfall.c:73: warning: passing argument 2 of ‘signal’ from incompatible pointer type > Run hpfall, and see if LED lights and disk parks if you "drop" a > computer. (*) $ sudo ./hpfall & The LED lights up yellow, but I have problems telling if the disk gets parked or not. One time I got a green led and seemingly a fair amount of activity immediately after getting the yellow led. After looking at hpfall.c, I checked /sys/block/sda/device/unload_heads after a drop: $ cat /sys/block/sda/device/unload_heads 19616 $ cat /sys/block/sda/device/unload_heads 0 The last was at most 2 seconds after the first, certainly not 20... Wouldn't it be good to have locks/unlocks registered in the logs when /sys/block/sda/device/unload_heads changes (assuming the actual write will get delayed until the head is unparked)? Cheers, FJP -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists