linux-kernel - [patch] x86: Unneeded assignment to tsk in recent x86 change, v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 22 Jan 2009 08:33:57 +0100
From:	Uros Bizjak <ubizjak@...il.com>
To:	Mikael Pettersson <mikpe@...uu.se>
Cc:	linux-kernel@...r.kernel.org
Subject: [patch] x86: Unneeded assignment to tsk in recent x86 change, v2

On Wed, Jan 21, 2009 at 10:13 PM, Mikael Pettersson <mikpe@...uu.se> wrote:

Impact: Cleanup.

Remove unneeded assignment to tsk in recent x86 change.

>  > Hm, I'm not sure I see the inconsistency here. Care to explain this
>  > inconsistency in a couple of words?
>
> You're initialising some variables in their declarations, and some
> using assignments at the start of the procedure body. In particular,
> for some reason you don't initialise 'mm' in its declaration even
> though you could do so for consistency with 'tsk'.
>
> However, I'm strongly in favour of separating declarations and
> initialisations (esp. ones that need actual computations), so
> rather than subjecting 'mm' to the treatment you gave 'tsk',
> just leave the code alone.
>

Patch v2 with the second hunk removed is attached to this message.

Thanks,
Uros.

View attachment "p.diff.txt" of type "text/plain" (447 bytes)