lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 25 Jan 2009 17:57:10 +0100 (CET) From: Jiri Kosina <jkosina@...e.cz> To: Jaswinder Singh Rajput <jaswinderlinux@...il.com> cc: Jiri Slaby <jirislaby@...il.com>, Dmitry Torokhov <dmitry.torokhov@...il.com>, linux-input@...r.kernel.org, marcel@...tmann.org, linux-kernel@...r.kernel.org, anssi.hannula@...il.com, gregkh@...e.de, Sam Ravnborg <sam@...nborg.org>, Ingo Molnar <mingo@...e.hu> Subject: Re: [PATCH 09/10] HID: add compat support On Sat, 24 Jan 2009, Jaswinder Singh Rajput wrote: > This leads to 3 headers_check warnings: > > usr/include/linux/hid.h:66: leaks CONFIG_HID to userspace where it is not valid > usr/include/linux/hid.h:69: extern's make no sense in userspace > usr/include/linux/hid.h:76: extern's make no sense in userspace > > So I am moving whole above block in #ifdef __KEREL__ > > If you have any objections, then let me know, now it will look like this: > > #endif /* HID_FF */ > > +#ifdef __KERNEL__ > #ifdef CONFIG_HID_COMPAT > #define HID_COMPAT_LOAD_DRIVER(name) \ > /* prototype to avoid sparse warning */ \ > @@ -804,6 +805,7 @@ EXPORT_SYMBOL(hid_compat_##name) > extern void hid_compat_##name(void); \ > hid_compat_##name(); \ > } while (0) > +#endif /* __KERNEL__ */ > > #endif Thanks for catching this. Could you please resend the patch to me, with proper changelog and Signed-off-by: line? Thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists