linux-kernel - Re: [PATCH RFC] sh: maple: Add support for SEGA Dreamcast VMU and clean up maple bus driver (3/3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 29 Jan 2009 10:34:43 -0000 (UTC)
From:	"Adrian McMenamin" <adrian@...golddream.dyndns.info>
To:	"Paul Mundt" <lethal@...ux-sh.org>,
	"Adrian McMenamin" <adrian@...golddream.dyndns.info>,
	"Greg KH" <greg@...ah.com>,
	"Dmitry Torokhov" <dmitry.torokhov@...il.com>,
	"dwmw2" <dwmw2@...radead.org>,
	"linux-sh" <linux-sh@...r.kernel.org>,
	"LKML" <linux-kernel@...r.kernel.org>,
	"linux-input" <linux-input@...r.kernel.org>,
	"MTD" <linux-mtd@...ts.infradead.org>
Subject: Re: [PATCH RFC] sh: maple: Add support for SEGA Dreamcast VMU and 
     clean up maple bus driver (3/3)

On Thu, January 29, 2009 2:57 am, Paul Mundt wrote:
> On Thu, Jan 29, 2009 at 12:18:07AM +0000, Adrian McMenamin wrote:
>> +	if (!(mdev->function & MAPLE_FUNC_KEYBOARD)) {
>> +		error = EINVAL;
>> +		goto fail;
>> +	}
>>
> What is this all about? If the function doesn't match, you should never
> enter the probe routine in the first place. The bus code should already
> get this right.
>

It does, it is a fragment of old code from when the bus code was wrong
which for reasons which pass understanding I rewrote rather than just
excised.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/