linux-kernel - Re: [PATCH] - UV fix compile error on IA64 & eliminate compiler warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 29 Jan 2009 14:33:08 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Jack Steiner <steiner@....com>
Cc:	tglx@...utronix.de, linux-kernel@...r.kernel.org,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] - UV fix compile error on IA64 & eliminate compiler
	warning


* Jack Steiner <steiner@....com> wrote:

> 
> The GRU driver is used on both IA64 & x86.
> The 2 architectures have different ways of detecting the
> platform type, ie. whether the platform is a UV system.
> Although it is possible to reconcile the 2 methods,
> only one place currently makes the test.
> 
> Also eliminate a warning message in uv.h.
> 
> Signed-off-by: Jack Steiner <steiner@....com>
> 
> 
> ---
>  arch/x86/include/asm/uv/uv.h   |    1 +
>  drivers/misc/sgi-gru/gru.h     |    2 --
>  drivers/misc/sgi-gru/grufile.c |    1 +
>  3 files changed, 2 insertions(+), 2 deletions(-)
> 
> Index: linux/arch/x86/include/asm/uv/uv.h
> ===================================================================
> --- linux.orig/arch/x86/include/asm/uv/uv.h	2009-01-28 12:43:27.000000000 -0600
> +++ linux/arch/x86/include/asm/uv/uv.h	2009-01-28 15:13:58.000000000 -0600
> @@ -2,6 +2,7 @@
>  #define _ASM_X86_UV_UV_H
>  
>  enum uv_system_type {UV_NONE, UV_LEGACY_APIC, UV_X2APIC, UV_NON_UNIQUE_APIC};
> +struct mm_struct;

hm, why is this needed?

>  #define IS_UV()		is_uv_system()

btw., why is there an ugly IS_UV() macro. All code should be using 
is_uv_system() and IS_UV() should be removed.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/