linux-kernel - Re: [PATCH 1/3] ide-cd: use ide_drive_t's rq in cdrom_queue_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 1 Feb 2009 17:04:50 +0100
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	petkovbb@...il.com
Cc:	linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org
Subject: Re: [PATCH 1/3] ide-cd: use ide_drive_t's rq in cdrom_queue_request_sense

On Tuesday 27 January 2009, Borislav Petkov wrote:
> On Tue, Jan 27, 2009 at 4:07 PM, Bartlomiej Zolnierkiewicz
> <bzolnier@...il.com> wrote:
> > On Monday 26 January 2009, Borislav Petkov wrote:
> >> There should be no functionality change resulting from this patch.
> >>
> >> Suggested-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
> >> Signed-off-by: Borislav Petkov <petkovbb@...il.com>
> >> ---
> >>  drivers/ide/ide-cd.c |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
> >> index d3d5fb6..3907466 100644
> >> --- a/drivers/ide/ide-cd.c
> >> +++ b/drivers/ide/ide-cd.c
> >> @@ -207,7 +207,7 @@ static void cdrom_queue_request_sense(ide_drive_t *drive, void *sense,
> >>                                     struct request *failed_command)
> >>  {
> >>       struct cdrom_info *info         = drive->driver_data;
> >> -     struct request *rq              = &info->request_sense_request;
> >> +     struct request *rq              = &drive->request_sense_rq;
> >
> > Don't we want to also remove now unused ->request_sense_request?
> 
> sure we do :)
> 
> --
> From: Borislav Petkov <petkovbb@...il.com>
> Date: Tue, 27 Jan 2009 17:42:28 +0100
> Subject: [PATCH 1/3] ide-cd: use ide_drive_t's rq in cdrom_queue_request_sense
> 
> There should be no functionality change resulting from this patch.
> 
> Suggested-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
> Signed-off-by: Borislav Petkov <petkovbb@...il.com>

applied
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/