linux-kernel - Re: [PATCH] atmel-mci: fix initialization of dma slave data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Feb 2009 16:01:35 +0100
From:	Hans-Christian Egtvedt <hans-christian.egtvedt@...el.com>
To:	Dan Williams <dan.j.williams@...el.com>
Cc:	Atsushi Nemoto <anemo@....ocn.ne.jp>,
	"kernel@...32linux.org" <kernel@...32linux.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"hskinnemoen@...el.com" <hskinnemoen@...el.com>
Subject: Re: [PATCH] atmel-mci: fix initialization of dma slave data

On Sat, 31 Jan 2009 09:26:43 -0700
Dan Williams <dan.j.williams@...el.com> wrote:

> Subject: atmel-mci: fix initialization of dma slave data
> 
> From: Dan Williams <dan.j.williams@...el.com>
> 
> The conversion of atmel-mci to dma_request_channel missed the
> initialization of the channel dma_slave information.  The filter_fn
> passed to dma_request_channel is responsible for initializing the
> channel's private data.  This implementation has the additional
> benefit of enabling a generic client-channel data passing mechanism.
> 

FWIW I ran this through an ALSA sound driver I'm working on for AVR32,
uses the DW DMA controller and this was exactly what I needed to pass
on the information about the slave. Seems to behave fine on my setup,
I'm working against the 2.6.29-rc3 tag.

> Reviewed-by: Atsushi Nemoto <anemo@....ocn.ne.jp>
> Signed-off-by: Dan Williams <dan.j.williams@...el.com>

<snipp patch which adds a private pointer to struct dma_chan>

-- 
Best regards,
Hans-Christian Egtvedt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/