linux-kernel - Re: [PATCH] do_pipe cleanup: drop its last user in arch/alpha/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 2 Feb 2009 12:48:22 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Cheng Renquan <crquan@...il.com>
Cc:	rth@...ddle.net, linux-alpha@...r.kernel.org,
	ink@...assic.park.msu.ru, viro@...iv.linux.org.uk, cr_quan@....com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] do_pipe cleanup: drop its last user in arch/alpha/

On Sat, 24 Jan 2009 12:43:50 +0800
Cheng Renquan <crquan@...il.com> wrote:

> --- a/arch/alpha/kernel/osf_sys.c
> +++ b/arch/alpha/kernel/osf_sys.c
> @@ -46,7 +46,7 @@
>  #include <asm/hwrpb.h>
>  #include <asm/processor.h>
>  
> -extern int do_pipe(int *);
> +extern int do_pipe_flags(int *, int);


From: Andrew Morton <akpm@...ux-foundation.org>

WARNING: externs should be avoided in .c files
#42: FILE: arch/alpha/kernel/osf_sys.c:49:
+extern int do_pipe_flags(int *, int);

total: 0 errors, 1 warnings, 36 lines checked

./patches/do_pipe-drop-its-last-user-in-arch-alpha.patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Al Viro <viro@...iv.linux.org.uk>
Cc: Cheng Renquan <crquan@...il.com>
Cc: Ivan Kokshaysky <ink@...assic.park.msu.ru>
Cc: Jens Axboe <jens.axboe@...cle.com>
Cc: Richard Henderson <rth@...ddle.net>
Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
---

 arch/alpha/kernel/osf_sys.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff -puN arch/alpha/kernel/osf_sys.c~do_pipe-drop-its-last-user-in-arch-alpha-checkpatch-fixes arch/alpha/kernel/osf_sys.c
--- a/arch/alpha/kernel/osf_sys.c~do_pipe-drop-its-last-user-in-arch-alpha-checkpatch-fixes
+++ a/arch/alpha/kernel/osf_sys.c
@@ -14,6 +14,7 @@
 #include <linux/sched.h>
 #include <linux/kernel.h>
 #include <linux/mm.h>
+#include <linux/fs.h>
 #include <linux/smp.h>
 #include <linux/smp_lock.h>
 #include <linux/stddef.h>
@@ -46,8 +47,6 @@
 #include <asm/hwrpb.h>
 #include <asm/processor.h>
 
-extern int do_pipe_flags(int *, int);
-
 /*
  * Brk needs to return an error.  Still support Linux's brk(0) query idiom,
  * which OSF programs just shouldn't be doing.  We're still not quite
_


OK?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/