linux-kernel - Re: [PATCH] Fix the warning of uninitialized value in driver/serial/8250.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Feb 2009 11:03:16 +0100
From:	Laurent Pinchart <laurentp@...-semaphore.com>
To:	wenji.huang@...cle.com
Cc:	linux-serial@...r.kernel.org, lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Fix the warning of uninitialized value in driver/serial/8250.c

On Monday 02 February 2009 10:10:06 Wenji Huang wrote:
> This patch is to remove the the warning of uninitialized i in
> driver/serial/8250.c
>
> Signed-off-by: Wenji Huang <wenji.huang@...cle.com>
>
> diff -Nurh drivers/serial/8250.c.Orig drivers/serial/8250.c
> --- drivers/serial/8250.c.Orig  2009-02-02 14:02:47.000000000 -0500
> +++ drivers/serial/8250.c       2009-02-02 14:03:30.000000000 -0500
> @@ -1678,7 +1678,7 @@
>
>   static void serial_unlink_irq_chain(struct uart_8250_port *up)
>   {
> -       struct irq_info *i;
> +       struct irq_info *i = NULL;
>          struct hlist_node *n;
>          struct hlist_head *h;

gcc is wrong, i can't be used uninitialized in that function. You should use 
the following construct instead to suppress the warning without generating any 
code.

	struct irq_info *uninitialized_var(i);

Best regards,

-- 
Laurent Pinchart
CSE Semaphore Belgium

Chaussee de Bruxelles, 732A
B-1410 Waterloo
Belgium

T +32 (2) 387 42 59
F +32 (2) 387 42 75

Download attachment "signature.asc " of type "application/pgp-signature" (198 bytes)