[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 2 Feb 2009 11:42:16 +0000
From: Mark Brown <broonie@...ena.org.uk>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: sameo@...nedhand.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] mfd: Improve diagnostics for WM8350 ID register probe
On Mon, Feb 02, 2009 at 11:00:17AM +0000, Mark Brown wrote:
> On Fri, Jan 30, 2009 at 12:10:09PM -0800, Andrew Morton wrote:
> > Reading a bunch of bytes into a u16 looks a bit fishy from the endianness
> > point of view?
> Hrm, yeah. I'll send a patch for this. Shouldn't be an issue in
> practice since this is a primary PMIC and is unlikely to be used to
> power anything with the wrong endianness.
...or not, the code is already OK. The next block of code uses
be16_to_cpu() on all the values before they're actually used.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists