linux-kernel - Re: [possible BUG] PM suspend warning in 2.6.29-rc3-00227-gf1dd849

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 3 Feb 2009 21:58:19 +0800
From:	Ming Lei <tom.leiming@...il.com>
To:	reinette chatre <reinette.chatre@...el.com>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	Linux-kernel <linux-kernel@...r.kernel.org>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>
Subject: Re: [possible BUG] PM suspend warning in 2.6.29-rc3-00227-gf1dd849

2009/2/3 reinette chatre <reinette.chatre@...el.com>:
> Ming,
>
> On Mon, 2009-02-02 at 06:14 -0800, Ming Lei wrote:
>> After applying your patch, following is the dmesg output, so it is the
>> iwl3945 driver that does not save pci state.
>
> Could you please test with the patch below?

reinette,

The previous warning during pm suspending does disappear after
applying your patch.

Thanks!

>
> Thank you
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c
> b/drivers/net/wireless/iwlwifi/iwl3945-base.c
> index 95d0198..5b44d32 100644
> --- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
> +++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
> @@ -8143,6 +8143,7 @@ static int iwl3945_pci_suspend(struct pci_dev
> *pdev, pm_message_t state)
>                priv->is_open = 1;
>        }
>
> +       pci_save_state(pdev);
>        pci_set_power_state(pdev, PCI_D3hot);
>
>        return 0;
> @@ -8153,6 +8154,7 @@ static int iwl3945_pci_resume(struct pci_dev
> *pdev)
>        struct iwl3945_priv *priv = pci_get_drvdata(pdev);
>
>        pci_set_power_state(pdev, PCI_D0);
> +       pci_restore_state(pdev);
>
>        if (priv->is_open)
>                iwl3945_mac_start(priv->hw);
>
>
>
>
>



-- 
Lei Ming
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/