linux-kernel - Re: [patch] unlock_kernel() on error path in sx_fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 4 Feb 2009 10:49:13 +0100
From:	Rogier Wolff <R.E.Wolff@...Wizard.nl>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Dan Carpenter <error27@...il.com>, R.E.Wolff@...Wizard.nl,
	linux-kernel@...r.kernel.org
Subject: Re: [patch] unlock_kernel() on error path in sx_fw_ioctl()

On Tue, Feb 03, 2009 at 08:58:57PM -0800, Andrew Morton wrote:
> fix another such path - missed func_exit().

This is not critical. It's just debug. When DEBUG_CALLS (or something
like that) is active, it will print "leaving function ... ". 

Indeed if it's missing, you might start to think why DID it return,
but not print the message... or. howcome it's still in that function
doing stuff that isn't there. Anyway, looking into it would provide
you more info that it was returning the error.....

Anyway, nice to clean it up "while we're at it". 

	Roger. 


-- 
** R.E.Wolff@...Wizard.nl ** http://www.BitWizard.nl/ ** +31-15-2600998 **
**    Delftechpark 26 2628 XH  Delft, The Netherlands. KVK: 27239233    **
*-- BitWizard writes Linux device drivers for any device you may have! --*
Q: It doesn't work. A: Look buddy, doesn't work is an ambiguous statement. 
Does it sit on the couch all day? Is it unemployed? Please be specific! 
Define 'it' and what it isn't doing. --------- Adapted from lxrbot FAQ
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/