linux-kernel - Re: [GIT PULL -tip v3] fix 39 'make headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 04 Feb 2009 16:28:30 +0200
From:	Avi Kivity <avi@...hat.com>
To:	Jaswinder Singh Rajput <jaswinderlinux@...il.com>
CC:	Sam Ravnborg <sam@...nborg.org>, Ingo Molnar <mingo@...e.hu>,
	Jaswinder Singh Rajput <jaswinder@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL -tip v3] fix 39 'make headers_check' warnings

Jaswinder Singh Rajput wrote:
> On Mon, Jan 19, 2009 at 5:23 PM, Avi Kivity <avi@...hat.com> wrote:
>   
>> Sam Ravnborg wrote:
>>     
>>>> They are.  This bits advertise to userspace what features kvm supports,
>>>> both compile- and run-time.
>>>>
>>>>         
>>> This is wrong...
>>> The headers does not change with the kernel configuration and advertising
>>> the
>>> kvm features via a .h file like this is simply plain broken.
>>>
>>>       
>> Ok.  Don't know why I thought unifdef was supplied with the full
>> configuration.
>>
>>     
>>> You cannot assume that the header files are generated with the exact same
>>> config
>>> as used by the running kernel.
>>>
>>>       
>> This is just for arch specific defines.  I'll move these to asm/kvm.h.
>>
>>     
>>> And userspace has in no way access to the CONFIG_ namespace which is
>>> purely kernel-internal.
>>>
>>> I cannot see how you have ever seen kcm advertise that for example
>>> KVM_CAP_USER_NMI
>>> equals to 22 because CONFIG_X86 is never (supposed to be) defined in
>>> userspace -
>>> except if you did so yourself by some means.
>>>
>>>       
>> We did, we ship a hacked-up kvm.h (generated by unifdef) with our userspace.
>>
>>     
>
> latest -tip is still giving 'make headers_check' warnings:
>  usr/include/linux/kvm.h:61: leaks CONFIG_X86 to userspace where it is not valid
>  usr/include/linux/kvm.h:64: leaks CONFIG_X86 to userspace where it is not valid
>  usr/include/linux/kvm.h:387: leaks CONFIG_X86 to userspace where it
> is not valid
>  usr/include/linux/kvm.h:391: leaks CONFIG_X86 to userspace where it
> is not valid
>  usr/include/linux/kvm.h:396: leaks CONFIG_X86 to userspace where it
> is not valid
>
> So should I resend my patch or you are going to move this stuff
>   

Your patch is broken.  I'll push mine shortly.

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/