linux-kernel - Re: [PATCH 1/4] ptrace: kill __ptrace_detach(), fix ->exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed,  4 Feb 2009 16:56:39 -0800 (PST)
From:	Roland McGrath <roland@...hat.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Jerome Marchand <jmarchan@...hat.com>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] ptrace: kill __ptrace_detach(), fix ->exit_state check

> Move the code from __ptrace_detach() to its single caller and kill this
> helper.
> 
> Also, fix the ->exit_state check, we shouldn't wake up EXIT_DEAD tasks.

Yes, though that is probably impossible anyway.  Perhaps in a de_thread
race, but probably harmlessly does nothing.  Anyway, certainly fine to
change the test to match all others of the same ilk.

> Actually, I think task_is_stopped_or_traced() makes more sense, but this
> needs another patch.

Agreed.  It is one of those nasty cases where the old semantics are
"clearly" wrong, but it's very hard not to worry that some obscure
combination of circumstances means that some common-enough case actually
depends on the "wrong" wakeup.

> Signed-off-by: Oleg Nesterov <oleg@...hat.com>

Acked-by: Roland McGrath <roland@...hat.com>

Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/