| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 05 Feb 2009 11:30:27 -0800 From: Harvey Harrison <harvey.harrison@...il.com> To: Eric Van Hensbergen <ericvh@...il.com> Cc: v9fs-developer@...ts.sourceforge.net, linux-kernel@...r.kernel.org Subject: Re: [PATCH] 9p: fix endian issues [attempt 2] On Thu, 2009-02-05 at 13:16 -0600, Eric Van Hensbergen wrote: > On Thu, Feb 5, 2009 at 1:10 PM, Harvey Harrison > <harvey.harrison@...il.com> wrote: > > On Thu, 2009-02-05 at 13:05 -0600, ericvh@...il.com wrote: > >> From: Eric Van Hensbergen <ericvh@...il.com> > >> > >> When the changes were done to the protocol last release, some endian > >> bugs crept in. This patch fixes those endian problems and has been > >> verified to run on 32/64 bit and x86/ppc architectures. > >> > >> This version of the patch incorporates the correct annotations > >> for endian variables. > >> > >> Signed-off-by: Eric Van Hensbergen <ericvh@...il.com> > > > > Looks better to me. > > > > Thanks for your help. Unfortunately, I was trigger happy with the > commit and added whitespace, so everyone gets to see this patch one > more time (sorry). > Actually for the read case, you may want to look at leXX_to_cpus which will swap the value in-place through a pointer, so you can avoid the temporary endian variable. Harvey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists