linux-kernel - Re: [PATCH 3/4] ptrace: reintroduce __ptrace_detach() as a callee of ptrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu,  5 Feb 2009 12:37:31 -0800 (PST)
From:	Roland McGrath <roland@...hat.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Jerome Marchand <jmarchan@...hat.com>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] ptrace: reintroduce __ptrace_detach() as a callee
	of ptrace_exit()

> > Given its content, this function now better belongs in ptrace.c, I think.
> 
> I don't completely agree... This helper imho has nothing to do with
> ptracing, except it does __ptrace_unlink(). But OK, I will move it
> if you prefer. 

Obviously where it goes is not a big deal.  But I think it's clear that it
has everything to do with ptrace and nothing to do with anything else.
It resolves a situation that can only arise because of ptrace magic.

> In that case we should export task_detached().

Or just recognize that this trivial wrapper around == -1 has little
value two lines away from a place where = -1 is done explicitly.  
Really, the "abstraction" is more confusing than not in this function, IMHO.

Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/