linux-kernel - Re: [PATCH] platform driver:fix incorrect use of 'platform_bus_type' with 'struct device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 06 Feb 2009 17:12:45 -0200
From:	"Henrique de Moraes Holschuh" <hmh@....eng.br>
To:	"David Brownell" <david-b@...bell.net>, tom.leiming@...il.com
Cc:	greg@...ah.com, kay.sievers@...y.org, LW@...o-electronics.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform driver:fix incorrect use of 'platform_bus_type'
 with 'struct device_driver'

On Fri, 6 Feb 2009 09:59:22 -0800, "David Brownell" <david-b@...bell.net> said:
> On Friday 06 February 2009, tom.leiming@...il.com wrote:
> > From: Ming Lei <tom.leiming@...il.com>
> > 
> > This patch fixes the bug reported in
> >         http://bugzilla.kernel.org/show_bug.cgi?id=11681.
> > 
> > "Lots of device drivers register a 'struct device_driver' with
> > the '.bus' member set to '&platform_bus_type'. This is wrong,
> > since the platform_bus functions expect the 'struct device_driver'
> > to be wrapped up in a 'struct platform_driver' which provides
> > some additional callbacks (like suspend_late, resume_early).
> > The effect may be that platform_suspend_late() uses bogus data
> > outside the device_driver struct as a pointer pointer to the
> > device driver's suspend_late() function or other hard to
> > reproduce failures."(Lothar Wassmann)
> > 
> > Signed-off-by: Ming Lei <tom.leiming@...il.com>
> 
> I just glanced at this ... but those parts looked like
> good fixes to this family of bugs.  Thanks.

Indeed!  Thanks for the patch.

Can we mark the drivers not fixed by this patch as BROKEN or at the very 
least block them from compiling if suspend support is enabled?  They hose
suspend and resume depending on random luck...

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/