linux-kernel - [PATCH] Propagate CRAMFS uncompression errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 Feb 2009 21:55:29 -0500
From:	"David VomLehn (dvomlehn)" <dvomlehn@...co.com>
To:	<linux-kernel@...r.kernel.org>
Subject: [PATCH] Propagate CRAMFS uncompression errors

If cramfs_uncompress_block detects an error uncompressing it will
return a zero value. This patch checks the return value and propagates
the error back up to the block layer.

Signed-off-by: David VomLehn <dvomlehn@...co.com>
---
 fs/cramfs/inode.c |   10 +++++++++-
 1 files changed, 9 insertions(+), 1 deletions(-)

diff --git a/fs/cramfs/inode.c b/fs/cramfs/inode.c
index a07338d..6ff8a5e 100644
--- a/fs/cramfs/inode.c
+++ b/fs/cramfs/inode.c
@@ -493,7 +493,15 @@ static int cramfs_readpage(struct file *file,
struct page * page)
 	memset(pgdata + bytes_filled, 0, PAGE_CACHE_SIZE -
bytes_filled);
 	kunmap(page);
 	flush_dcache_page(page);
-	SetPageUptodate(page);
+
+	if (bytes_filled == 0) {
+		ClearPageUptodate(page);
+		SetPageError(page);
+	}
+
+	else
+		SetPageUptodate(page);
+
 	unlock_page(page);
 	return 0;
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/