lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 8 Feb 2009 14:47:51 +0100 From: Jean Delvare <khali@...ux-fr.org> To: Frank Seidel <frank@...eidel.de> Cc: Frank Seidel <fseidel@...e.de>, linux kernel <linux-kernel@...r.kernel.org>, akpm@...ux-foundation.org, ben-linux@...ff.org, linux-i2c@...r.kernel.org, w.sang@...gutronix.de, "David S. Miller" <davem@...emloft.net>, ukleinek@...ormatik.uni-freiburg.de, Frans Pop <elendil@...net.nl>, Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com> Subject: Re: [PATCH] i2c: add missing KERN_* constants to printks On Sun, 08 Feb 2009 14:11:52 +0100, Frank Seidel wrote: > Hi, > > Jean Delvare wrote: > >> + printk(KERN_ERR "i2c: ICR: %08x ISR: %08x\n" > >> "i2c: log: ", readl(_ICR(i2c)), readl(_ISR(i2c))); > >> for (i = 0; i < i2c->irqlogidx; i++) > >> printk("[%08x:%08x] ", i2c->isrlog[i], i2c->icrlog[i]); > > > > This last printk also lacks a log level. You can't add it in the loop, > > but you could add one printk before the loop, printing just the log level. > > Isn't the last printk just a followup of the previous KERN_ERR which > doesn't have a newline? And i'm told only on new line beginnings the > loglevel should be set. I mean the (first) printk in the loop, not the last printk in this function. So what I am suggesting is: + printk(KERN_DEBUG); for (i = 0; i < i2c->irqlogidx; i++) printk("[%08x:%08x] ", i2c->isrlog[i], i2c->icrlog[i]); printk("\n"); -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists