linux-kernel - [PATCH 0/6] ide: more unifications of ATA and ATAPI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Feb 2009 00:19:45 +0100
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	linux-ide@...r.kernel.org
Cc:	Borislav Petkov <petkovbb@...il.com>,
	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH 0/6] ide: more unifications of ATA and ATAPI support


After this patchset we have a valid struct ide_cmd available also for
ATA_CMD_PACKET commands and comparing struct ide_atapi_pc with ide_cmd it
seems that there are many similarities between them and that we may just
merge both structs (this should also allow us to unify ide-cd code with
non-ide-cd one in ide-atapi.c later).  From the quick look the only gotcha
is REQUEST SENSE handling, ->request_sense_pc needs to be converted to
->request_sense_cmd and we have to be careful with choosing right 'cmd'
in *_issue_pc()...

Borislav, please take a look and tell me what do you think about it
(also feel free to go ahead with patches :-)...

On top of "[PATCH 0/9] ide: unify request completion methods" patchset
[ http://lkml.org/lkml/2009/2/9/398 ].

diffstat:
 drivers/ide/alim15x3.c     |    9 ++---
 drivers/ide/au1xxx-ide.c   |   23 +++----------
 drivers/ide/cmd64x.c       |    6 +--
 drivers/ide/cs5536.c       |    2 -
 drivers/ide/hpt366.c       |    6 +--
 drivers/ide/icside.c       |   14 +-------
 drivers/ide/ide-atapi.c    |   77 +++++++++++++++++++++------------------------
 drivers/ide/ide-cd.c       |   14 +++++++-
 drivers/ide/ide-disk.c     |   14 ++++----
 drivers/ide/ide-dma-sff.c  |   33 +++++++------------
 drivers/ide/ide-dma.c      |   16 ++++-----
 drivers/ide/ide-eh.c       |    9 ++---
 drivers/ide/ide-floppy.c   |   32 +++++++++++-------
 drivers/ide/ide-io.c       |   14 ++++----
 drivers/ide/ide-iops.c     |   42 ++++++++----------------
 drivers/ide/ide-tape.c     |   19 ++++++++---
 drivers/ide/ide-taskfile.c |   57 ++++++++++++++++-----------------
 drivers/ide/it821x.c       |    2 -
 drivers/ide/ns87415.c      |    6 +--
 drivers/ide/pdc202xx_old.c |    4 +-
 drivers/ide/pmac.c         |   27 ++++-----------
 drivers/ide/sc1200.c       |    2 -
 drivers/ide/scc_pata.c     |   21 ++++--------
 drivers/ide/sgiioc4.c      |   21 ++++--------
 drivers/ide/siimage.c      |    2 -
 drivers/ide/sl82c105.c     |    2 -
 drivers/ide/tc86c001.c     |    2 -
 drivers/ide/trm290.c       |   16 ++-------
 drivers/ide/tx4939ide.c    |   28 ++++++----------
 include/linux/ide.h        |   36 +++++++++------------
 30 files changed, 251 insertions(+), 305 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/