linux-kernel - Re: [PATCH] lis3lv02d: add axes knowledge of HP Pavilion dv5 models

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Feb 2009 12:07:37 +0100
From:	Giuseppe Bilotta <giuseppe.bilotta@...il.com>
To:	Éric Piel <eric.piel@...mplin-utc.net>
Cc:	Palatis Tseng <palatis@...il.com>, Pavel Machek <pavel@...e.cz>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] lis3lv02d: add axes knowledge of HP Pavilion dv5 models

On Tue, Feb 10, 2009 at 11:34 AM, Éric Piel <eric.piel@...mplin-utc.net> wrote:
> (putting back the cc's, please keep them when answering)
>
> Palatis Tseng schreef:
>> Éric Piel 提到:
>>> No problem, the patch from Giuseppe will get the axex fine :-)
>>>
>>> However, could you let use know if you too, on your laptop, have huge
>>> fluctuations even when the laptop is not moving? Could you give an idea
>>> of the minimum and maximum values of each axis when the laptop is set
>>> normally on the desk without touching it?
>>>
>>> Thanks,
>>> Eric
>> I took a look at the patch but my axis on dv5 is Y_inverted (instead of
>> X_inverted.) i patched my lis3lv02d.c and added:
>>
>> === cut here ===
>>    AXIS_DMI_MATCH("HPDV5", "HP Pavilion dv5", y_inverted),
>> === cut here ===
>>
>> and neverball worked just correct with it so i'm kinda sure my patch
>> about the axis should be correct.
>>
>> i've also tested with x_inverted, but whenever i evaluate the left side
>> of my notebook the ball goes to the left side too which is not real-world
>> behavier.
>>
>> mine is a HP Pavilion dv5 1003ax with AMD PUMA platform.
>> `dmidecode | grep "Product Name" says:
>> (under "System Information"...)
>>    Product Name: HP Pavilion dv5 Notebook PC
> Giuseppe,
> Palatis mentions that on his laptop the sensor is actually y_inverted.
> Could you check your laptop? In particular it would be nice if you could
>  describe the values for the four positions defined in the documentation
> file. BTW, what is the exact version of your laptop? Is it the same as
> Palatis?

With my patch applied:

Left raised: 0 -> 32k
Right raised: 0 -> -32k

Front raised: 1 -> -32k
back raised: 1 -> 32k

Upside down: 2 -> 32k

So it seems that my model inverts the Z axis too, I'll have to fix
that. However, this last test is tricky because unless the laptop is
completely upside down the Z axis can go from -32k to +32k with just a
couple of degrees (around the 90°)

I'll update my patch to invert the X and Z axis for my model.

> Palatis, could you let us know if you also have a lot of "noise" in the
> values. That is, if when using jstest /dev/input/js0 you see big changes
> in the values. Is it like on Giuseppe's laptop of around 8000?
>
> Moreover I'm wondering if this could be an error on LSB/MSB ordering.
> Maybe looking at the raw values (cat
> /sys/devices/platform/lis3lv02d/position) would give more insight...

amd64 architecture here. Laptop flat:

oblomov@...omov:~$ cat /sys/devices/platform/lis3lv02d/position
(-256,256,14592)
oblomov@...omov:~$ cat /sys/devices/platform/lis3lv02d/position
(0,256,14848)
oblomov@...omov:~$ cat /sys/devices/platform/lis3lv02d/position
(-256,256,14848)
oblomov@...omov:~$ cat /sys/devices/platform/lis3lv02d/position
(-256,0,14336)
oblomov@...omov:~$ cat /sys/devices/platform/lis3lv02d/position
(-256,512,14336)
oblomov@...omov:~$ cat /sys/devices/platform/lis3lv02d/position
(256,256,14592)

Left edge raised:
oblomov@...omov:~$ cat /sys/devices/platform/lis3lv02d/position
(5120,512,13312)
oblomov@...omov:~$ cat /sys/devices/platform/lis3lv02d/position
(5632,512,13312)

You might be onto something.

The dmi for my Pavilion is:

Handle 0x0001, DMI type 1, 27 bytes
System Information
        Manufacturer: Hewlett-Packard
        Product Name: HP Pavilion dv5 Notebook PC
        Version: F.09
        Serial Number: (x-ed out)
        UUID: (x-ed out)
        Wake-up Type: Power Switch
        SKU Number: (x-ed out)
        Family: 103C_5335KV

So it might be that different pavilions have different sensors?

-- 
Giuseppe "Oblomov" Bilotta
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/