linux-kernel - Re: [RFC] vmscan: initialize sc->nr_reclaimed in do_try_to_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Feb 2009 21:31:04 +0900
From:	MinChan Kim <minchan.kim@...il.com>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Cc:	Johannes Weiner <hannes@...xchg.org>,
	Rik van Riel <riel@...hat.com>,
	William Lee Irwin III <wli@...ementarian.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [RFC] vmscan: initialize sc->nr_reclaimed in do_try_to_free_pages()

On Tue, Feb 10, 2009 at 9:06 PM, KOSAKI Motohiro
<kosaki.motohiro@...fujitsu.com> wrote:
>> > static int __zone_reclaim(struct zone *zone, gfp_t gfp_mask, unsigned int order)
>> > {
>> >        /* Minimum pages needed in order to stay on node */
>> >        const unsigned long nr_pages = 1 << order;
>> >        struct task_struct *p = current;
>> >        struct reclaim_state reclaim_state;
>> >        int priority;
>> >        struct scan_control sc = {
>> >                .may_writepage = !!(zone_reclaim_mode & RECLAIM_WRITE),
>> >                .may_swap = !!(zone_reclaim_mode & RECLAIM_SWAP),
>> >                .swap_cluster_max = max_t(unsigned long, nr_pages,
>> >                                        SWAP_CLUSTER_MAX),
>> >                .gfp_mask = gfp_mask,
>> >                .swappiness = vm_swappiness,
>> >                .isolate_pages = isolate_pages_global,
>> > +               .nr_reclaimed = 0;
>> >        };
>>
>> Hmm.. I missed that.  Thanks.
>> There is one in shrink_all_memory.
>
> No.
> __zone_reclaim isn't a part of shrink_all_memory().
> Currently, shrink_all_memory() don't use sc.nr_reclaimed member.
> (maybe, it's another wrong thing ;)

Hmm.. You're right.
As Johannes pointed out,
too many page shrinking can degrade resume performance.

We need to bale out in shrink_all_memory.
Other people, thought ?

-- 
Kinds regards,
MinChan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/