lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Feb 2009 10:08:39 +0900 From: Tejun Heo <tj@...nel.org> To: Brian Gerst <brgerst@...il.com> CC: hpa@...or.com, jeremy@...p.org, tglx@...utronix.de, mingo@...e.hu, linux-kernel@...r.kernel.org, x86@...nel.org, rusty@...tcorp.com.au Subject: Re: [PATCH 03/11] x86: fix math_emu register frame access Hello, Brian. Brian Gerst wrote: >> { >> printk(KERN_EMERG >> "math-emulation not enabled and no coprocessor found.\n"); >> @@ -910,16 +910,19 @@ asmlinkage void math_emulate(long arg) >> } >> #endif /* CONFIG_MATH_EMULATION */ >> >> -dotraplinkage void __kprobes >> -do_device_not_available(struct pt_regs *regs, long error) >> +dotraplinkage void __kprobes do_device_not_available(struct pt_regs regs) > > Why did you change this to pass by value? This is called from the > generic trap handler (error_code), which already passes the pt_regs > pointer in %eax. Ah.. right, my bad. I somehow thought dotraplinkage is asmlinkage on x86_32. Yeah, the original code was fine in that area, but then again most other trap functions take struct pt_regs. Anyways, you're gonna post patches to convert trap functions to take pointer to pt_regs, right? Can you please fix this one up together with those? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists