linux-kernel - Re: [PATCH] Kbuild: Disable the -Wformat-security gcc flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Feb 2009 22:48:52 +0100
From:	Floris Kraak <randakar@...il.com>
To:	Pavel Machek <pavel@...e.cz>
Cc:	Roland Dreier <rdreier@...co.com>, Sam Ravnborg <sam@...nborg.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Trivial Patch Monkey <trivial@...nel.org>
Subject: Re: [PATCH] Kbuild: Disable the -Wformat-security gcc flag

On Tue, Feb 10, 2009 at 9:24 PM, Pavel Machek <pavel@...e.cz> wrote:
> On Wed 2009-02-04 14:26:45, Roland Dreier wrote:
>>  > Before judging on this patch could you please post what warning it
>>  > triggers and one or a few patches to fix some of them.
>>
>> The warnings are things like:
>>
>>     init/main.c: In function 'start_kernel':
>>     init/main.c:557: warning: format not a string literal and no format arguments
>>
>
> Would it be possible to declare linux_banner const or something?
>
>> diff --git a/init/main.c b/init/main.c
>> index 8442094..78fc0d8 100644
>> --- a/init/main.c
>> +++ b/init/main.c
>> @@ -554,7 +554,7 @@ asmlinkage void __init start_kernel(void)
>>       boot_cpu_init();
>>       page_address_init();
>>       printk(KERN_NOTICE);
>> -     printk(linux_banner);
>> +     printk("%s", linux_banner);
>
> Actually
>         printk(KERN_NOTICE "%s", linux_banner);
>
> is a better fix that will save some code, too.
>

Noted. Adding that to the patch tomorrow.

Regards,
Floris
---
"They that give up essential liberty to obtain temporary safety,
deserve neither liberty nor safety."
  -- Ben Franklin

"The course of history shows that as a government grows, liberty
decreases."
  -- Thomas Jefferson
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/