linux-kernel - Re: [patch] timerfd add flags check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 11 Feb 2009 11:35:55 -0800 (PST)
From:	Davide Libenzi <davidel@...ilserver.org>
To:	mtk.manpages@...il.com
cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Greg KH <greg@...ah.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [patch] timerfd add flags check

On Wed, 11 Feb 2009, Michael Kerrisk wrote:

> On Tue, Feb 10, 2009 at 1:36 PM, Michael Kerrisk
> <mtk.manpages@...glemail.com> wrote:
> > On Tue, Feb 10, 2009 at 12:31 PM, Davide Libenzi
> > <davidel@...ilserver.org> wrote:
> >> Like Michael requested, this patch adds a missing check for valid flags in
> >> timerfd_settime(), and make it return EINVAL in case some extra bits are
> >> set.
> >>
> >> Michael said:
> >> If this is to be any use to userland apps that want to check flag
> >> support (perhaps it is too late already), then the sooner we get it
> >> into the kernel the better: 2.6.29 would be good; earlier stables as
> >> well would be even better.
> >>
> >> Acked-by: Michael Kerrisk <mtk.manpages@...il.com>
> >>
> >>
> >> Signed-off-by: Davide Libenzi <davidel@...ilserver.org>
> >
> > Davide, one question: is the TFD_FLAGS_SET constant below needed?
> 
> Davide, Ping!  I see Andrew already took the patch, which seems to
> define this unnecessary macro.

Yes, Michael! I will post a correction to Andrew. OTOH an un-necessary 
macro defined could even be passed into the lower priority queue, don't 
you think?



- Davide


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/