linux-kernel - Re: Can request_irq be called under spinlock?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 13 Feb 2009 10:52:31 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Johannes Weiner <hannes@...xchg.org>
Cc:	Jeremy Fitzhardinge <jeremy@...p.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Yinghai Lu <yinghai@...nel.org>,
	the arch/x86 maintainers <x86@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Can request_irq be called under spinlock?


* Johannes Weiner <hannes@...xchg.org> wrote:

> From: Johannes Weiner <hannes@...xchg.org>
> Subject: irq: use GFP_KERNEL for action allocation in request_irq()
> 
> request_irq() calls into proc code via __setup_irq() which is not safe
> in an atomic context, so request_irq() can itself use the more
> reliable GFP_KERNEL allocation for the action descriptor.
> 
> Signed-off-by: Johannes Weiner <hannes@...xchg.org>
> ---
> 
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index 291f036..0f2b3b6 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -709,7 +709,7 @@ int request_irq(unsigned int irq, irq_handler_t handler,
>  	if (!handler)
>  		return -EINVAL;
>  
> -	action = kmalloc(sizeof(struct irqaction), GFP_ATOMIC);
> +	action = kmalloc(sizeof(struct irqaction), GFP_KERNEL);
>  	if (!action)
>  		return -ENOMEM;

Good catch - applied to tip:irq/genirq, thanks Johannes!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/