linux-kernel - Re: [OpenWrt-Devel] [PATCH] bcm47xx: Fix GPIO API return codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 15 Feb 2009 14:27:36 +0100
From:	Florian Fainelli <florian@...nwrt.org>
To:	openwrt-devel@...ts.openwrt.org
Cc:	Michael Buesch <mb@...sch.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [OpenWrt-Devel] [PATCH] bcm47xx: Fix GPIO API return codes

Hi Michael,

Le Saturday 14 February 2009 21:27:19 Michael Buesch, vous avez écrit :
> The GPIO API is supposed to return 0 or a negative error code,
> but the SSB GPIO functions return the bitmask of the GPIO register.
> Fix this by ignoring the bitmask and always returning 0. The SSB GPIO
> functions can't fail.

At some point we might want to convert the existing board code to use gpiolib. 
I will try to come up with a patch for this later this afternoon.

Otherwise, your patch looks good.
-- 
Best regards, Florian Fainelli
Email : florian@...nwrt.org
http://openwrt.org
-------------------------------

Download attachment "signature.asc " of type "application/pgp-signature" (198 bytes)