linux-kernel - Re: &&//|| typo ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Feb 2009 16:07:46 +0100
From:	roel kluin <roel.kluin@...il.com>
To:	Jörg-Volker Peetz <jvpeetz@....de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: &&//|| typo ?

2009/2/16 Jörg-Volker Peetz <jvpeetz@....de>:
> Hi,
>
> inspired by the mail http://lkml.org/lkml/2009/2/15/159
> I did
>
> grep -Ern '\!=.*\|\|.*\!=' linux-2.6.28.5
>
> and found the following tests which are always true if the tested variable is
> not NaN:

> linux-2.6.28.5/arch/x86/kvm/vmx.c:1794: if ((ss.type != 3) || (ss.type != 7))
> linux-2.6.28.5/arch/x86/kvm/vmx.c:1837: if ((tr.type != 3) || (tr.type != 11))
> /* TODO: Check if guest is in IA32e mode */

Ok, I sent a patch

> linux-2.6.28.5/net/sunrpc/auth_unix.c:122:      if (cred->uc_uid != acred->uid ||
> cred->uc_gid != acred->gid)
>
> linux-2.6.28.5/net/sunrpc/svcauth_unix.c:747:   if (svc_getu32(argv) !=
> htonl(RPC_AUTH_NULL) || svc_getu32(argv) != 0) {
> linux-2.6.28.5/net/sunrpc/svcauth_unix.c:833:   if (svc_getu32(argv) !=
> htonl(RPC_AUTH_NULL) || svc_getu32(argv) != 0) {
>
> linux-2.6.28.5/net/sunrpc/auth_gss/gss_krb5_seqnum.c:78:        if ((plain[4] !=
> plain[5]) || (plain[4] != plain[6])
> linux-2.6.28.5/net/sunrpc/auth_gss/gss_krb5_seqnum.c:79:                                   || (plain[4] !=
> plain[7]))

I don't think this is a bug, this tests whether all are the same.

> linux-2.6.28.5/drivers/block/paride/pf.c:569:           if ((buf[k + offs] != 0x20) ||
> (buf[k + offs] != l))

I am not sure this is a bug: l can become 0x20.

> linux-2.6.28.5/drivers/block/paride/pg.c:425:           if (c != ' ' || c != l)

also c can become ' '

> linux-2.6.28.5/drivers/block/paride/pt.c:506:           if ((buf[k + offs] != 0x20) ||
> (buf[k + offs] != l))

again

> linux-2.6.28.5/drivers/misc/sgi-gru/grukservices.c:612: if (word0 != word1 ||
> word0 != MAGIC) {

Not sure either.

>
> linux-2.6.28.5/drivers/scsi/gvp11.c:283:        if (qq != q || qq != 0xff)      /* should be
> read only, all 1's */

again


> linux-2.6.28.5/drivers/scsi/FlashPoint.c:6045:                          if(bit_cnt != 0 || bit_cnt != 8)

I also spotted this but it's in comment and a pretty old driver, so I
didn't bother.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/