linux-kernel - Re: [PATCH] sound: pcxhr.h replace signed one-bit bitfields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 20 Feb 2009 08:43:19 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sound: pcxhr.h replace signed one-bit bitfields

At Thu, 19 Feb 2009 11:58:37 -0800,
Harvey Harrison wrote:
> 
> The usage and comments make it clear values of 1/0 were intended
> rather than -1/0
> 
> Noticed by sparse:
> sound/pci/pcxhr/pcxhr.h:100:20: error: dubious one-bit signed bitfield
> sound/pci/pcxhr/pcxhr.h:101:22: error: dubious one-bit signed bitfield
> sound/pci/pcxhr/pcxhr.h:102:24: error: dubious one-bit signed bitfield
> sound/pci/pcxhr/pcxhr.h:103:21: error: dubious one-bit signed bitfield
> sound/pci/pcxhr/pcxhr.h:104:25: error: dubious one-bit signed bitfield
> sound/pci/pcxhr/pcxhr.h:105:20: error: dubious one-bit signed bitfield
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>

Applied now.  Thanks!


Takashi

> ---
>  sound/pci/pcxhr/pcxhr.h |   12 ++++++------
>  1 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/sound/pci/pcxhr/pcxhr.h b/sound/pci/pcxhr/pcxhr.h
> index ac9c3b3..a661a18 100644
> --- a/sound/pci/pcxhr/pcxhr.h
> +++ b/sound/pci/pcxhr/pcxhr.h
> @@ -97,12 +97,12 @@ struct pcxhr_mgr {
>  	int capture_chips;
>  	int fw_file_set;
>  	int firmware_num;
> -	int is_hr_stereo:1;
> -	int board_has_aes1:1;	/* if 1 board has AES1 plug and SRC */
> -	int board_has_analog:1;	/* if 0 the board is digital only */
> -	int board_has_mic:1;	/* if 1 the board has microphone input */
> -	int board_aes_in_192k:1;/* if 1 the aes input plugs do support 192kHz */
> -	int mono_capture:1;	/* if 1 the board does mono capture */
> +	unsigned int is_hr_stereo:1;
> +	unsigned int board_has_aes1:1;	/* if 1 board has AES1 plug and SRC */
> +	unsigned int board_has_analog:1;	/* if 0 the board is digital only */
> +	unsigned int board_has_mic:1;	/* if 1 the board has microphone input */
> +	unsigned int board_aes_in_192k:1;/* if 1 the aes input plugs do support 192kHz */
> +	unsigned int mono_capture:1;	/* if 1 the board does mono capture */
>  
>  	struct snd_dma_buffer hostport;
>  
> -- 
> 1.6.2.rc1.175.g96b8a
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/