linux-kernel - Re: [s390] next Feb 18: defconfig build break

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 20 Feb 2009 11:23:39 +0100
From:	Martin Schwidefsky <schwidefsky@...ibm.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	Mike Frysinger <vapier.adi@...il.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	"Sachin P. Sant" <sachinp@...ibm.com>, linux-s390@...r.kernel.org,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	heiko.carstens@...ibm.com
Subject: Re: [s390] next Feb 18: defconfig build break

Hi Rusty,

On Thu, 19 Feb 2009 09:13:26 +1030
Rusty Russell <rusty@...tcorp.com.au> wrote:

> Here's the s390 fix:
> 
> Subject: s390: allow usage of string functions in linux/string.h

Thanks for the fix.
 
> Because when including asm/string.h from arch/s390/lib/string.c we
> don't declare the string ops we are about to define, and
> linux/string.h barfs.
> 
> The fix is to declare them in this IN_ARCH_STRING_C case, but in
> general I wonder if there's a neater fix.

The out-of-line version of the string functions in
arch/s390/lib/string.c needs EXPORT_SYMBOL and other stuff. To fix the
problem without the seperate out-of-line prototypes would required to
avoid the inclusing of linux/string.h. Which would be fragile if
possible at all. So I think your patch is the best way to deal with the
problem.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/