linux-kernel - [patch] w1_ds2433: clear the validcrc flag after a write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sun, 22 Feb 2009 22:19:16 -0600
From:	Ben Gardner <gardner.ben@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Ben Gardner <gardner.ben@...il.com>,
	Evgeniy Polyakov <johnpol@....mipt.ru>
Subject: [patch] w1_ds2433: clear the validcrc flag after a write

The w1_ds2433 driver does not read from the hardware if the CRC was valid on the last read.
The validcrc flag should be cleared after a write so that the new value can be read.

Signed-off-by: Ben Gardner <gardner.ben@...il.com>
Signed-off-by: Evgeniy Polyakov <johnpol@....mipt.ru>

--- linux-2.6.28.5.orig/drivers/w1/slaves/w1_ds2433.c	2009-02-16 13:52:06.000000000 -0600
+++ linux-2.6.28.5/drivers/w1/slaves/w1_ds2433.c	2009-02-16 13:52:27.000000000 -0600
@@ -156,6 +156,9 @@
  */
 static int w1_f23_write(struct w1_slave *sl, int addr, int len, const u8 *data)
 {
+#ifdef CONFIG_W1_SLAVE_DS2433_CRC
+	struct w1_f23_data *f23 = sl->family_data;
+#endif
 	u8 wrbuf[4];
 	u8 rdbuf[W1_PAGE_SIZE + 3];
 	u8 es = (addr + len - 1) & 0x1f;
@@ -196,7 +199,9 @@
 
 	/* Reset the bus to wake up the EEPROM (this may not be needed) */
 	w1_reset_bus(sl->master);
-
+#ifdef CONFIG_W1_SLAVE_DS2433_CRC
+	f23->validcrc &= ~(1 << (addr >> W1_PAGE_BITS));
+#endif
 	return 0;
 }
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/