linux-kernel - Re: [PATCHSET x86/core/percpu] improve the first percpu chunk allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Feb 2009 22:16:59 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Tejun Heo <tj@...nel.org>, Yinghai Lu <yinghai@...nel.org>
Cc:	rusty@...tcorp.com.au, tglx@...utronix.de, x86@...nel.org,
	linux-kernel@...r.kernel.org, hpa@...or.com, jeremy@...p.org,
	cpw@....com, nickpiggin@...oo.com.au, ink@...assic.park.msu.ru
Subject: Re: [PATCHSET x86/core/percpu] improve the first percpu chunk
	allocation


> > >   git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git 
> > >   tj-percpu

ok, but these seem to be genuinely yours.

one build failure:

 arch/x86/kernel/setup_percpu.c: In function ‘setup_per_cpu_areas’:
 arch/x86/kernel/setup_percpu.c:442: error: ‘ptr’ undeclared (first use in this function)
 arch/x86/kernel/setup_percpu.c:442: error: (Each undeclared identifier is reported only once
 arch/x86/kernel/setup_percpu.c:442: error: for each function it appears in.)

one new warning:

 mm/percpu.c: In function ‘pcpu_map’:
 mm/percpu.c:604: warning: unused variable ‘last’

and one tip:master merge impact due to API change:

 kernel/trace/trace_functions_graph.c: In function ‘graph_trace_close’:
 kernel/trace/trace_functions_graph.c:836: error: implicit declaration of function ‘percpu_free’

that's free_percpu() now, right?

Btw., why was this rename done? We generally standardize on 
hierarchical names, going from the more general to the more 
specific names, left to right. So we have 
<subsystem>_<functionality>_<subtype> sort of names generally.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/