linux-kernel - Re: [PATCH] Input notifier support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Feb 2009 12:31:57 +0530
From:	Trilok Soni <soni.trilok@...il.com>
To:	Kyungmin Park <kmpark@...radead.org>
Cc:	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	dmitry.torokhov@...il.com
Subject: Re: [PATCH] Input notifier support

Hi Kyungmin,

> diff --git a/drivers/input/input.c b/drivers/input/input.c
> index 1730d73..7e96635 100644
> --- a/drivers/input/input.c
> +++ b/drivers/input/input.c
> @@ -274,6 +274,8 @@ void input_event(struct input_dev *dev,
>                add_input_randomness(type, code, value);
>                input_handle_event(dev, type, code, value);
>                spin_unlock_irqrestore(&dev->event_lock, flags);
> +               if (type == EV_KEY)
> +                       input_notifier_call_chain(value, &code);

This check will be done for every input_report_xxx calls, even for
touchscreen events (in which case of course it will fail), and I don't
think this is optimal solution. Users should be given an option to
disable this if they don't need this notification mechanism.

How about moving this to input_report_key?

-- 
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/