linux-kernel - Re: [patch 5/7] make netfilter use strict integer types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Feb 2009 16:24:38 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Jan Engelhardt <jengelh@...ozas.de>
CC:	arnd@...db.de, Sam Ravnborg <sam@...nborg.org>,
	Kyle McMartin <kyle@...radead.org>,
	Ingo Molnar <mingo@...e.hu>,
	Jaswinder Singh Rajput <jaswinderrajput@...il.com>,
	mingo@...hat.com, dwmw2@...radead.org,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	netfilter-devel@...r.kernel.org, coreteam@...filter.org
Subject: Re: [patch 5/7] make netfilter use strict integer types

Jan Engelhardt wrote:
> On Thursday 2009-02-26 00:51, arnd@...db.de wrote:
> 
>> Netfilter traditionally uses BSD integer types in its
>> interface headers. This changes it to use the Linux
>> strict integer types, like everyone else.
> 
> I _strongly disagree_ with this move. Userspace also has the uintX
> types via <stdint.h>/<cstdint>, and now you are adding a dependency
> on linux/types.h, not to mention that your step can lead to compile
> time piling up.
> 
> IMHO, __uXX should be replaced by uintX_t, but a move this great I
> will leave to future generations because there is just too much
> persisting opinions wrt. such proposal. As such I'd like to join
> and persist on my position and that uintX that we have should be kept.
> 
>> -	u_int8_t flags;
>> -	u_int8_t mask;
>> +	__u8 flags;
>> +	__u8 mask;

Not to mention the fact that the standard type is uint8_t, not u_int8_t 
as the file currently have, which makes it double broken.
	
	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/