lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Fri, 27 Feb 2009 01:55:30 +0100
From:	Hannes Eder <hannes@...neseder.net>
To:	dri-devel@...ts.sourceforge.net,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Cc:	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] drivers/gpu/drm: comment out dead code

[Added To]

On Sun, Jan 18, 2009 at 4:28 PM, Hannes Eder <hannes@...neseder.net> wrote:
> The functions:
>
>  drm_crtc_from_fb
>  drm_mode_validate_clocks
>
> are not used, so comment them out.
>
> Signed-off-by: Hannes Eder <hannes@...neseder.net>
> ---
>  drivers/gpu/drm/drm_crtc.c  |    2 ++
>  drivers/gpu/drm/drm_modes.c |    2 ++
>  2 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index d378306..c44bbde 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -254,6 +254,7 @@ void *drm_mode_object_find(struct drm_device *dev, uint32_t id, uint32_t type)
>  }
>  EXPORT_SYMBOL(drm_mode_object_find);
>
> +#ifdef UNUSED
>  /**
>  * drm_crtc_from_fb - find the CRTC structure associated with an fb
>  * @dev: DRM device
> @@ -278,6 +279,7 @@ static struct drm_crtc *drm_crtc_from_fb(struct drm_device *dev,
>        }
>        return NULL;
>  }
> +#endif /* UNUSED */
>
>  /**
>  * drm_framebuffer_init - initialize a framebuffer
> diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
> index c0cfe39..8ebcf51 100644
> --- a/drivers/gpu/drm/drm_modes.c
> +++ b/drivers/gpu/drm/drm_modes.c
> @@ -341,6 +341,7 @@ void drm_mode_validate_size(struct drm_device *dev,
>  }
>  EXPORT_SYMBOL(drm_mode_validate_size);
>
> +#ifdef UNUSED
>  /**
>  * drm_mode_validate_clocks - validate modes against clock limits
>  * @dev: DRM device
> @@ -376,6 +377,7 @@ static void drm_mode_validate_clocks(struct drm_device *dev,
>                        mode->status = MODE_CLOCK_RANGE;
>        }
>  }
> +#endif /* UNUSED */
>
>  /**
>  * drm_mode_prune_invalid - remove invalid modes from mode list
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ