linux-kernel - Re: [PATCH 2/2] unaligned: add load/store_{endian}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Mar 2009 16:18:26 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Harvey Harrison <harvey.harrison@...il.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Christoph Hellwig <hch@...radead.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Boaz Harrosh <bharrosh@...asas.com>
Subject: Re: [PATCH 2/2] unaligned: add load/store_{endian}_noalign API



On Mon, 2 Mar 2009, Harvey Harrison wrote:
>
> Add a typed API with the usual argument ordering and use load/store,
> this API is also consistent with the aligned versions.

This naming is horrible. It doesn't match the normal pattern we have in 
the kernel. 

Why not just try to fix the current (well-named) "get_unaligned_le16()" 
problems, instead of introducing a new (and badly named) version of them.

So NAK on both of these.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/