linux-kernel - Re: [PATCH 3/3] ide-{cd,floppy}: do not map all cmds to an sg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 Mar 2009 17:52:41 +0100
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	petkovbb@...il.com
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] ide-{cd,floppy}: do not map all cmds to an sg

On Thursday 05 March 2009, Borislav Petkov wrote:
> Hi,
> 
> > Unrelated to the original issue that the patch tries to fix
> > (sg mapping no data commands which OOPS-es w/ DEBUG_VIRTUAL=y):
> > - moving ide_init_sg_cmd()+ide_map_sg() to ide_issue_pc()
> > - converting the code to use blk_rq_bytes()
> 
> aah, ok, now I could get exactly what you meant :). However, (!) ide-floppy is
> potentially broken in the same way for data-less cmds since we unconditionally

Indeed, you are right but it seems that this is not a new problem.

Wait... it makes things "worse" as there should have been 3 patches:
(IOW _three_ patchpoints! ;):

- ide-cd fix for problematic patch
- ide-floppy fix for mainline
- ide-atapi cleanup for pata tree

Thanks,
Bart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/