linux-kernel - Re: [TIP][RFC 2/7] futex: futex_top

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 7 Mar 2009 16:16:18 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Darren Hart <dvhltc@...ibm.com>
cc:	"lkml, " <linux-kernel@...r.kernel.org>,
	Steven Rostedt <srostedt@...hat.com>,
	Sripathi Kodi <sripathik@...ibm.com>,
	John Stultz <johnstul@...ux.vnet.ibm.com>
Subject: Re: [TIP][RFC 2/7] futex: futex_top_waiter()

On Mon, 2 Mar 2009, Darren Hart wrote:

> From: Darren Hart <dvhltc@...ibm.com>
> 
> Improve legibility by wrapping finding the top waiter in a function.  This
> will be used by the follow-on patches for enabling requeue pi.
> +static struct futex_q *futex_top_waiter(struct futex_hash_bucket *hb,
> +					union futex_key *key)

Can we just have *head as argument instead of *hb ?

> +{
> +	struct plist_head *head;
> +	struct futex_q *this;
> +	struct futex_q *top_waiter = NULL;

  	struct futex_q *this;

> +	head = &hb->chain;
> +	plist_for_each_entry(this, head, list) {
> +		if (match_futex(&this->key, key)) {
  		   	return this;		    

> +			top_waiter = this;
> +			break;
> +		}
> +	}
> +	return top_waiter;

  	return NULL;

Makes the function half the size.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/