linux-kernel - Re: [v2][PATCH 2/5] Parse mount options just once and copy them to super block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 7 Mar 2009 09:31:29 -0800
From:	Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>
To:	"Serge E. Hallyn" <serue@...ibm.com>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>, hpa@...or.com, hch@....de,
	sukadev@...ibm.com, Containers <containers@...ts.osdl.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [v2][PATCH 2/5] Parse mount options just once and copy them to
	super block

Sorry, I had not responded to this:

Serge E. Hallyn [serue@...ibm.com] wrote:
| > -	if (new)
| > -		return new_pts_mount(fs_type, flags, data, mnt);
| > +	memset(&opts, 0, sizeof(opts)); 
| > +	if (data) {
| > +		error = parse_mount_options(data, PARSE_MOUNT, &opts);
| 
| Is there any reason to keep the PARSE_MOUNT argument to
| parse_mount_options?

Yes parse_mount_options() needs to know whether it is a MOUNT or 
REMOUNT operation - MOUNT operation should clear 'newinstance' to
default before parsing, but REMOUNT should not.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/