linux-kernel - Re: [PATCH] debug cgroup: remove unneeded cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Mar 2009 19:43:32 -0700
From:	Paul Menage <menage@...gle.com>
To:	Li Zefan <lizf@...fujitsu.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux Containers <containers@...ts.linux-foundation.org>
Subject: Re: [PATCH] debug cgroup: remove unneeded cgroup_lock

On Wed, Mar 11, 2009 at 6:47 PM, Li Zefan <lizf@...fujitsu.com> wrote:
> Since we are in cgroup write handler, so the cgrp is valid, so we
> don't have to hold cgroup_mutex when calling cgroup_task_count().
> One similar example is in cgroup_tasks_open().
>
> Signed-off-by: Li Zefan <lizf@...fujitsu.com>

Acked-by: Paul Menage <menage@...gle.com>

(Although this conflicts with a patch that I'm about to send out that
moves the code from cgroup_debug.c into cgroup.c to allow internal
details to be reported in the debug.* files.)

> ---
>  kernel/cgroup_debug.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/cgroup_debug.c b/kernel/cgroup_debug.c
> index daca620..0c92d79 100644
> --- a/kernel/cgroup_debug.c
> +++ b/kernel/cgroup_debug.c
> @@ -40,9 +40,7 @@ static u64 taskcount_read(struct cgroup *cont, struct cftype *cft)
>  {
>        u64 count;
>
> -       cgroup_lock();
>        count = cgroup_task_count(cont);
> -       cgroup_unlock();
>        return count;
>  }
>
> --
> 1.5.4.rc3
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/